Stu2 add websockets #295
Merged
Stu2 add websockets #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From https://github.com/HL7/fhircast-docs/wiki/Websocket-proposal with some additional specificity. Remove May2019Ballot from menu.
wmaethner
suggested changes
Oct 28, 2019
per Will's review
fix some links and remove references to source diagrams/flowcharts because they're hosted on google drive .... :(
Necessary to correlate event notification "requests" with event notification "responses" -- because, truly, there's no such thing as a request or a response in websockets.
`hub.channel.endpoint` to be included in websockets unsubscribes, callback/secret/challenge only in webhook, clarify additive/subtractive nature of a subscription
for websockets to exchange the same info that intent verification exchanges over webhook
|
Fixes #299 |
wmaethner
reviewed
Nov 15, 2019
|
|
||
| If OAuth 2.0 authentication is used, this POST request SHALL contain the Bearer access token in the HTTP Authorization header. | ||
|
|
||
| Hubs SHALL allow subscribers to re-request subscriptions that are already activated. Each subsequent and verified request to a Hub to subscribe or unsubscribe SHALL override the previous subscription state for a specific topic / callback URL combination. | ||
| Hubs SHALL allow subscribers to re-request subscriptions that are already activated. Each subsequent and verified request to a Hub to subscribe or unsubscribe SHALL override the previous subscription state for a specific `hub.topic`, `hub.callback` / `hub.channel.endpoint` url, and `hub.events` combination. For example, a subscriber MAY modify its subscription by subscribing to or unsubscribing from additional events by sending subscription requests for additional events with the same topic and callback/endpoint url. |
There was a problem hiding this comment.
So are the unique identifying combos topic/callback (for webhook) and endpoint/events (for websocket)? The only real difference between the two methods is the callback and endpoint so shouldn't the rest be the same? So shouldn't topic be included in the websockets uniqueness and what about events for webhook?
There was a problem hiding this comment.
Read this wrong, this is what I expected.
wmaethner
approved these changes
Nov 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First take on formal websocket support in spec.