Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix table formatting and calendar layout #1625

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ShubhamShekhawat
Copy link

Solves the issue #1618

@ShubhamShekhawat
Copy link
Author

I have made changes to the hsf.css file to fix the table formatting issue. The table is now more responsive and visually cleaner.
I adjusted the padding, border, and background color for the table rows, as well as the alignment of the table headers.
Please check if the changes look good on various screen sizes and confirm that the table formatting issue is resolved.
If any other issue let me know.

@ShubhamShekhawat ShubhamShekhawat changed the title Fix table formatting in CSS Fix table formatting in CSS....Solves #1618 Dec 18, 2024
@graeme-a-stewart graeme-a-stewart changed the title Fix table formatting in CSS....Solves #1618 Fix table formatting and calendar layout Jan 7, 2025
@graeme-a-stewart
Copy link
Member

Hello @ShubhamShekhawat - thanks for working on these issues.

Right now there are a lot of formatting/whitespace changes which make finding the real changes harder - I would suggest you avoid changes like that in the future.

I also cannot see any actual changes to the website formatting. You added .calendar styles, but these are not used anywhere that I can see.

Also, you suppressed the . training-module CSS - was that on purpose?

Neither can I see differences in the table formatting, comparing your version with the current deployed version.

Are there some commits missing from the PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants