Port to Winnow #133
Open
Port to Winnow #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I want to be clear, just because I did this, there is no pressure to adopt it. I did this to explore how people use nom to see if there are areas of improvement for Winnow. Turns out, this library's use of nom is pretty straightforward. Winnow was originally forked from nom to unblock improvements on `toml_edit`. For more context on Winnow, see - [High-level comparison with nom](https://docs.rs/winnow/latest/winnow/_topic/why/index.html#nom) - [Key API differences](https://docs.rs/winnow/latest/winnow/_topic/nom/index.html#api-differences) - [Origin story](https://epage.github.io/blog/2023/02/winnow-toml-edit-combine-nom/) including [another take on differences from nom](https://epage.github.io/blog/2023/02/winnow-toml-edit-combine-nom/#winnow) and then [more differences](https://epage.github.io/blog/2023/07/winnow-0-5-the-fastest-rust-parser-combinator-library/) I see this has an MSRV of 1.64. I used an older patch release to satisfy that. Winnow's latest MSRV is 1.65. This does have a minor breaking change in that the feature `nom` was removed in favor of `winnow`. As these features are coming from optional dependencies, I'm assuming they are not intended to be features and you do not offer compatibility guarentees on them.
|
Due to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to be clear, just because I did this, there is no pressure to adopt it. I did this to explore how people use nom to see if there are areas of improvement for Winnow. Turns out, this library's use of nom is pretty straightforward.
Winnow was originally forked from nom to unblock improvements on
toml_edit. For more context on Winnow, seeI see this has an MSRV of 1.64. I used an older patch release to satisfy that. Winnow's latest MSRV is 1.65.
This does have a minor breaking change in that the feature
nomwas removed in favor ofwinnow. As these features are coming from optional dependencies, I'm assuming they are not intended to be features and you do not offer compatibility guarentees on them.