Miscellanous updates #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saxofon
commented
Mar 28, 2024
saxofon
commented
- send OBIS data in separate mqtt messages
- only send data that has changed
- debug logging via mqtt
- build procedures automated in Makefile
added 3 commits
March 28, 2024 17:03
* send OBIS data in separate mqtt messages * only send data that has changed * debug logging via mqtt * build procedures automated in Makefile Signed-off-by: Per Hallsmark <[email protected]>
Signed-off-by: Per Hallsmark <[email protected]>
Signed-off-by: Per Hallsmark <[email protected]>
|
Yes, that is a good idea!
…On Thu, 18 Apr 2024 at 20:54, Stefan Karlsson ***@***.***> wrote:
@stefan-karlsson commented on this pull request.
________________________________
In Makefile:
> +
+$(shell basename $(PICO_RST)):
+ curl -O $(PICO_RST)
+
+$(shell basename $(MP)):
+ curl -O $(MP)
+
+$(shell basename $(UMQTT)):
+ curl -LRJO $(UMQTT)
+
+.PHONY: dependencies
+dependencies: $(shell basename $(PICO_RST)) $(shell basename $(MP)) $(shell basename $(UMQTT))
+
+.PHONY: deploy
+deploy: dependencies
+ cp $(shell basename $(PICO_RST)) /run/media/per/RPI-RP2
I would remove the references to "per".
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
|
||
| .PHONY: deploy | ||
| deploy: dependencies | ||
| cp $(shell basename $(PICO_RST)) /run/media/per/RPI-RP2 |
There was a problem hiding this comment.
Suggested change
| cp $(shell basename $(PICO_RST)) /run/media/per/RPI-RP2 | |
| cp $(shell basename $(PICO_RST)) /media/$(USER)/RPI-RP2 |
| deploy: dependencies | ||
| cp $(shell basename $(PICO_RST)) /run/media/per/RPI-RP2 | ||
| sleep 15 | ||
| cp $(shell basename $(MP)) /run/media/per/RPI-RP2 |
There was a problem hiding this comment.
Suggested change
| cp $(shell basename $(MP)) /run/media/per/RPI-RP2 | |
| cp $(shell basename $(MP)) /media/$(USER)/RPI-RP2 |
|
|
||
| .PHONY: unit-test | ||
| unit-test: | ||
| sudo stty -F /dev/ttyUSB0 raw |
There was a problem hiding this comment.
I guess the path here depends on you operating system and slot selected
|
|
||
| .PHONY: mqtt-viewer | ||
| mqtt-viewer: | ||
| sub --auto-reconnect \ |
There was a problem hiding this comment.
Shall it be mqttcli sub --auto-reconnect ? Were is the mqttcli downloaded, multiple variants exists :)
| .PHONY: mqtt-viewer | ||
| mqtt-viewer: | ||
| sub --auto-reconnect \ | ||
| --broker tcp://$$(grep MQTTHost config.py.home | cut -d\' -f2):1883 \ |
There was a problem hiding this comment.
Suggested change
| --broker tcp://$$(grep MQTTHost config.py.home | cut -d\' -f2):1883 \ | |
| --broker tcp://$$(grep MQTTHost config.py | cut -d\' -f2):1883 \ |
| mqtt-viewer: | ||
| sub --auto-reconnect \ | ||
| --broker tcp://$$(grep MQTTHost config.py.home | cut -d\' -f2):1883 \ | ||
| --topic $$(grep MQTTTopic config.py.home | cut -d\' -f2)/# |
There was a problem hiding this comment.
Suggested change
| --topic $$(grep MQTTTopic config.py.home | cut -d\' -f2)/# | |
| --topic $$(grep MQTTTopic config.py | cut -d\' -f2)/# |
| PSK = '<PSK>' | ||
| MQTTHost = '<IP to mqtt server>' | ||
| MQTTTopic = 'electric-meter/main' |
There was a problem hiding this comment.
Maybee add user and password for the MQTT client?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.