Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use TextArea in AutoComplete instead of TextInput #2

Open
wants to merge 1 commit into
base: features/upgrade-to-yarn-berry
Choose a base branch
from

Conversation

carlgieringer
Copy link

@carlgieringer carlgieringer commented Apr 20, 2023

Not going to merge, just keeping track of branches.

  • Use TextAreaWithMessage in AutoComplete instead of TextField
  • Move useAutoComplete onKeyDown after handling so that it can see isDefaultPrevented().
  • Make maxLength and length optional to FormMessage
  • Calculate FormMessage's length from value.
  • Construct a missing id for a TextAreaWithMessage's FormMessage.

Since I added the built files to Git so that I could install from this branch, to see the 'real' changes, do:

git diff HEAD^..HEAD -- . ':(exclude)packages/autocomplete/es/' ':(exclude)packages/autocomplete/lib/' ':(exclude)packages/autocomplete/types/' ':(exclude)packages/form/es/' ':(exclude)packages/form/lib/' ':(exclude)packages/form/dist/' ':(exclude)packages/form/types/'

@carlgieringer carlgieringer force-pushed the features/textarea-autocomplete branch 2 times, most recently from 2ddf239 to c5d6ca8 Compare April 21, 2023 04:07
@carlgieringer carlgieringer force-pushed the features/textarea-autocomplete branch 5 times, most recently from f61736e to c5bb056 Compare April 21, 2023 05:40
@@ -16,6 +16,15 @@ packages/*/*.tsbuildinfo
/packages/material-icons/temp
!/packages/documentation/types

# Include the built files that we want to customize so that we can install from Github
!/packages/autocomplete/es
!/packages/autocomplete/lib
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed by jest.

@carlgieringer carlgieringer force-pushed the features/textarea-autocomplete branch from c5bb056 to 739fcf8 Compare April 21, 2023 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant