Merge pull request #6259 from mozilla/bitecs-object-menu-remove-fix

bitECS: Fix hiding the remove button from the object menu
Hubs-Foundation · Sep 15, 2023 · 8653fdd · 8653fdd
2 parents a1d31fa + d5aefe1
commit 8653fdd
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/bit-systems/object-menu.ts b/src/bit-systems/object-menu.ts
@@ -237,6 +237,7 @@ function updateVisibility(world: HubsWorld, menu: EntityID, frozen: boolean) {
   world.eid2obj.get(ObjectMenu.unpinButtonRef[menu])!.visible = visible && isPinned(target);
   world.eid2obj.get(ObjectMenu.pinButtonRef[menu])!.visible =
     visible && !isPinned(target) && canPin(APP.hubChannel!, target);
+  world.eid2obj.get(ObjectMenu.removeButtonRef[menu])!.visible = visible && !isPinned(target);
 
   // Hide unimplemented features for now.
   // TODO: Implement and show the buttons.
@@ -249,7 +250,6 @@ function updateVisibility(world: HubsWorld, menu: EntityID, frozen: boolean) {
   world.eid2obj.get(ObjectMenu.refreshButtonRef[menu])!.visible = false;
 
   [
-    ObjectMenu.removeButtonRef[menu],
     ObjectMenu.openLinkButtonRef[menu],
     ObjectMenu.cloneButtonRef[menu],
     ObjectMenu.rotateButtonRef[menu],