-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cp web doc updates #58
base: master
Are you sure you want to change the base?
Cp web doc updates #58
Conversation
On November 9th, 2016, we released the IBM Blockchain Service v1.0 based on HyperLedger fabric v0.6. All new networks created in bluemix will be this version. Support of the v0.4.2.x Bluemix Service based on the 0.5.3 Hyperledger Fabric has been deprecated. It is strongly recommended that if you have an existing network based on 0.5.3, you redeploy a new network and follow the instructions in the 2.0 branch. | ||
|
||
- [CP-Web - Branch v2.0](https://github.com/ibm-blockchain/cp-web/tree/v2.0) | ||
- Works with Hyperledger fabric `v0.6-developer-preview` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we mentioned bluemix service v1.0.0 here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's what I mean by "IBM Blockchain Service v1.0". Are you talking about that or something else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, you did mention it in the text. I was wondering if we should also put IBM Bluemix Blockchain Service v1.0.0+
or something like that in the list, like the list below it. I guess it's a minor detail and shouldn't hold up the PR.
``` | ||
# <a name="manbluenetwork"></a>Deploy the CP-Web App locally and connect to an IBM Blockchain Network running in Bluemix: | ||
|
||
1. Follow these instructions to [Set up your environment for running the demos](https://github.com/ptippett/marbles/blob/break_out_common_sections/demo_prereqs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd already created this document:
https://github.com/IBM-Blockchain/learn-chaincode/blob/master/docs/setup.md
The file you linked isn't a .md file, so it looks ugly in the git UI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok..that was a mistake..should be a .md. I'll fix. I do use that link you submitted. All my intermediate link does is:
tell them to ignore this if they did learn chaincode.
give them your link, but tell them all they need to do is git and node.js. Not everything else.
reducing that to a single link might be a good idea, just didn't do it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see that you do link to the learn-chaincode environment setup docs. All this needs, then is to change this file to a md file so that it formats properly in github.
1. Clone the CP-Web app to your local system so you can run it here | ||
To do this, run ```git clone http://gopkg.in/ibm-blockchain/cp-web.v2``` to clone the v2.0 branch to your local system. | ||
|
||
1. Follow the instructions to [Set up a new bluemix network or grab credentials from an existing network](https://github.com/ptippett/marbles/blob/break_out_common_sections/create_blockchain_bluemix.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should link to the bluemix docs for this:
https://console.ng.bluemix.net/docs/services/blockchain/index.html?pos=2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right. I didn't know that existed, but it's nice. I do like our instructions because they tell the user exactly what to click on to get the demo working, vs this more general overview. What I'd propose is we link from our instructions to the general ones. Something like "You're all ready to run the demo, but if you'd like more information on IBM BlockChain, the various plans and a detailed overview of the IBM BlockChain Dashboard, continue "
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with linking to the Bluemix docs.
|
||
1. Once you see this message you are good to go: | ||
|
||
[ibc-js] Deploying Chaincode - Complete |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't the message that cp-web spits out:
chain_setup.js Deployment request: {"fcn":"init","args":["a","100"],"chaincodePath":"chaincode/","certificatePath":"/certs/peer/cert.pem"}
chain_setup.js Successfully submitted chaincode deploy transaction 15b1c8e2c30a5a22fcdec456fa917332e5f070c75d3a7e73fd23500f2a4d80e4
chain_setup.js Will wait for 80 seconds after deployment for chaincode to startup
chain_setup.js Deploy 'complete'. Chaincode ID: 15b1c8e2c30a5a22fcdec456fa917332e5f070c75d3a7e73fd23500f2a4d80e4
user_manager: setup() called
------------------------------------------ Websocket Up ------------------------------------------
This is more accurate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. I just stole that from the previous documentation, but yeah the message you pasted is what I saw when I ran through this. I'll update.
added proper message to know when chaincode is running.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change the file for setting up your development environment to a markdown file. Also, I'd like to have the links to marbles documentation in this repository point to the actual marbles repository instead of the fork. Could we get these linked documents into marbles and update these links to point at those files?
Doc updates. These require the update in marbles as well since I broke out the common things into their separate sections.