Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Threat Fox API #266

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add Threat Fox API #266

wants to merge 1 commit into from

Conversation

theycallmecharlie
Copy link
Contributor

No description provided.

ChrisCollinsIBM
ChrisCollinsIBM requested changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@ChrisCollinsIBM ChrisCollinsIBM left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the additional submission.

I don't mind having 2 folders nested under one, but is Abuse API what these would be collectively know as? Or would a folder called abusse.ch be more meaningful?

Also, a small readme for each or a single readme in the abuse.ch folder explaining what these are for would certainly be helpful and increase their use.

And also can you please add a DCO signoff?

Thanks again for submitting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisCollinsIBM ChrisCollinsIBM ChrisCollinsIBM requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theycallmecharlie @ChrisCollinsIBM