Origin/trees issues fixes

[cdplagos]

Summary by Sourcery

This pull request introduces enhancements to the handling of subhalo properties by adding conditional logic based on a new parameter 'apply_fix_to_mass_swapping_events'. It refactors existing functions to separate the handling of central and satellite subhalos and adds a new function for recalculating angular momentum.

• Enhancements:
  • Introduced conditional logic to redefine central and satellite subhalo properties based on the new parameter 'apply_fix_to_mass_swapping_events'.
  • Refactored the function 'define_properties_halos' into two separate functions: 'define_properties_central_subhalos' and 'define_properties_satellite_subhalos'.
  • Added a new function 'redefine_angular_momentum' to handle the recalculation of angular momentum for subhalos.
  • Updated various functions to use the new 'apply_fix_to_mass_swapping_events' parameter to conditionally apply fixes to mass swapping events.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request addresses issues related to mass swapping events in the tree building and dark matter halo processes. It introduces a new parameter, apply_fix_to_mass_swapping_events, to conditionally apply fixes to subhalo properties. Functions have been refactored to handle central and satellite subhalo properties separately, and new functions have been added to redefine subhalo properties based on the new parameter. Additionally, minor typos and indentation issues have been fixed across multiple files.

File-Level Changes

Files	Changes
src/tree_builder.cpp include/tree_builder.h	Refactored functions to handle central and satellite subhalo properties separately and added conditional checks for mass swapping events.
src/dark_matter_halos.cpp include/dark_matter_halos.h	Introduced apply_fix_to_mass_swapping_events parameter and related logic to handle subhalo properties more accurately.
src/shark_runner.cpp src/disk_instability.cpp src/galaxy_mergers.cpp include/disk_instability.h include/galaxy_mergers.h	Updated constructors and function calls to pass dark_matter_params and handle mass swapping events.

---

Tips

• Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
• You can change your review settings at any time by accessing your dashboard:
  • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
  • Change the review language;
• You can always contact us if you have any questions or feedback.

[sourcery-ai]

Hey @cdplagos - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.}