Action to ensure header is build before merging #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bromiesTM
force-pushed
the
kh/dev/header-actions
branch
from
16ea02c to
e98043c
Compare
bromiesTM
force-pushed
the
kh/dev/header-actions
branch
from
e98043c to
0e71b0b
Compare
printminion-co
requested changes
Jul 23, 2024
| uses: peter-evans/create-pull-request@v6 | ||
| with: | ||
| commit-message: "build(header): auto build header" | ||
| committer: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> |
There was a problem hiding this comment.
not sure the committer has to be this email
| author: ${{ github.actor }} <${{ github.actor_id }}> | ||
| branch: auto-build-${{ github.head_ref }}-output | ||
| delete-branch: true | ||
| signoff: true |
There was a problem hiding this comment.
lets also add labels e.g labels: build:js, automated pr in order to be able to find autogenerated PRs.
Hint: The labels should be created beforehand
| run: cd IONOS/ && npm run lint | ||
|
|
||
| - name: Prettier | ||
| run: cd IONOS/ && npm run format:check |
| @@ -0,0 +1,46 @@ | |||
| name: Header Build and Create Pull Request | |||
There was a problem hiding this comment.
I like more "Build and Create Pull Request".. ...no strong opinion
There was a problem hiding this comment.
I tried to use "Header" as prefix everywhere as there could be additional components in the future, and it would be easier to distinguish them by a prefix
There was a problem hiding this comment.
probably we can name the file build-project.yml
There was a problem hiding this comment.
probably we can name the file lint.yml
bromiesTM
force-pushed
the
kh/dev/header-actions
branch
from
0e71b0b to
65467f3
Compare
bromiesTM
force-pushed
the
kh/dev/global-nav-header
branch
2 times, most recently
from
0c66e7e to
05d7c75
Compare
Signed-off-by: Kai Henseler <[email protected]>
Signed-off-by: Kai Henseler <[email protected]>
Signed-off-by: Kai Henseler <[email protected]>
Signed-off-by: Kai Henseler <[email protected]>
Signed-off-by: Kai Henseler <[email protected]>
bromiesTM
force-pushed
the
kh/dev/header-actions
branch
from
65467f3 to
d4c2b07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.