Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fb/dev/auth login page #33

Merged
merged 3 commits into from
Jan 5, 2025
Merged

Fb/dev/auth login page #33

merged 3 commits into from
Jan 5, 2025

Conversation

fracado
Copy link
Contributor

@fracado fracado commented Dec 18, 2024

No description provided.

@fracado fracado force-pushed the fb/dev/auth-login-page branch from 903ed08 to 8247458 Compare December 18, 2024 15:14
@fracado fracado force-pushed the fb/dev/auth-login-page branch 3 times, most recently from 7c18802 to 0a7d104 Compare December 19, 2024 15:57
Copy link
Collaborator

@bromiesTM bromiesTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review ok with suggestion to move code to another submodule

the part tag is needed to style the elements in shadow DOM with CSS, so that the styling is only applied to the header in 'body-login'

Signed-off-by: Franziska Bath <[email protected]>
duplicate variables removed, as we have them in nc_theming

Signed-off-by: Franziska Bath <[email protected]>
@fracado fracado force-pushed the fb/dev/auth-login-page branch from 0a7d104 to 28356e2 Compare January 3, 2025 16:54
@fracado fracado merged commit 09184a7 into main Jan 5, 2025
1 check passed
@fracado fracado deleted the fb/dev/auth-login-page branch January 5, 2025 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants