Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simplesettings to Easy Nextcloud #14

Merged
merged 3 commits into from
Jul 5, 2024

Conversation

thlehmann-ionos
Copy link

@thlehmann-ionos thlehmann-ionos commented Jun 13, 2024

Resolves: INTERNAL-6776

Summary

  1. Simplesettings was added
  2. It requires a the "redirects" config, which allows configuring redirects from paths to routes

Simplesettings

Small subset of the settings a user can make

Redirect config

Example config

"redirects" => { "^/path/regexp" => "an.apps.controller.route.locator" }

Use case

  • An administrator can configure another app as target for certain paths.

Differentiation from Apache redirects

  • this allows configuring redirects in one place and avoids spreading
    the configuration in multiple places.
  • the target route locator is more expressive/easier to trace than a
    path

Checklist

  • Code is properly formatted ✔️
  • Sign-off message is added to all commits ✔️
  • Tests (unit, integration, api and/or acceptance) are included ⏳
  • Screenshots before/after for front-end changes (not applicable)
  • Documentation (manuals or wiki) has been updated or is not required (not for our fork)
  • Backports requested where applicable (ex: critical bugfixes) (not for our fork)

@thlehmann-ionos thlehmann-ionos force-pushed the tl/dev/simplesettings-app branch from feb0651 to d5ded38 Compare June 13, 2024 16:11
@thlehmann-ionos thlehmann-ionos force-pushed the tl/dev/simplesettings-app branch from d5ded38 to a749a9d Compare June 25, 2024 08:09
@thlehmann-ionos thlehmann-ionos marked this pull request as ready for review June 25, 2024 08:50
@thlehmann-ionos thlehmann-ionos force-pushed the tl/dev/simplesettings-app branch from a749a9d to 928da8f Compare June 25, 2024 09:10
@printminion-co printminion-co self-requested a review June 27, 2024 07:35
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Copy link

@printminion-co printminion-co left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • review ok with requested changes
  • unfortunately we have no php unitests :( (do not see any tests for base.php)

.gitmodules Outdated Show resolved Hide resolved
lib/base.php Show resolved Hide resolved
lib/base.php Show resolved Hide resolved
config/redirects.config.php Outdated Show resolved Hide resolved
The "redirects" config allows configuring redirects from paths to routes.

Example config:

   "redirects" => { "^/path/regexp" => "an.apps.controller.route.locator" }

Use case:

* An administrator can configure another app as target for certain paths.

Differentiation from Apache redirects:

* this allows configuring redirects in one place and avoids spreading
  the configuration in multiple places.

* the target route locator is more expressive/easier to trace than a
  path

Signed-off-by: Thomas Lehmann <[email protected]>
simplesettings

The config for the previously added "redirects" feature.

Signed-off-by: Thomas Lehmann <[email protected]>
@thlehmann-ionos thlehmann-ionos force-pushed the tl/dev/simplesettings-app branch from a5b8dd4 to 5e6b3a4 Compare July 5, 2024 14:24
@thlehmann-ionos thlehmann-ionos merged commit 66a86ec into ionos-dev Jul 5, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants