-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add simplesettings to Easy Nextcloud #14
Conversation
feb0651
to
d5ded38
Compare
a55a58e
to
13a8659
Compare
d5ded38
to
a749a9d
Compare
13a8659
to
8208e25
Compare
a749a9d
to
928da8f
Compare
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- review ok with requested changes
- unfortunately we have no php unitests :( (do not see any tests for base.php)
Signed-off-by: Thomas Lehmann <[email protected]>
The "redirects" config allows configuring redirects from paths to routes. Example config: "redirects" => { "^/path/regexp" => "an.apps.controller.route.locator" } Use case: * An administrator can configure another app as target for certain paths. Differentiation from Apache redirects: * this allows configuring redirects in one place and avoids spreading the configuration in multiple places. * the target route locator is more expressive/easier to trace than a path Signed-off-by: Thomas Lehmann <[email protected]>
simplesettings The config for the previously added "redirects" feature. Signed-off-by: Thomas Lehmann <[email protected]>
a5b8dd4
to
5e6b3a4
Compare
Resolves: INTERNAL-6776
Summary
Simplesettings
Small subset of the settings a user can make
Redirect config
Example config
Use case
Differentiation from Apache redirects
the configuration in multiple places.
path
Checklist
Screenshots before/after for front-end changes(not applicable)Documentation (manuals or wiki) has been updated or is not required(not for our fork)Backports requested where applicable (ex: critical bugfixes)(not for our fork)