Mk/review/tl/dev/build apps #18
Conversation
Latest changes: * app install / enable refactoring * enabling apps Signed-off-by: Thomas Lehmann <[email protected]>
Actually required for the custom and external apps. Since the workflow starts in the project root, it initially "sees" the Nextcloud package.json. Since entering each app directory and setting up different Node/npm versions is no feasible anyway, let's set it here.
To track it as submodule in version control
Exclude node_modules, tests and GitHub/Gut dirs too.
Build simplesettings (custom) and user_oidc (external)
* Enable custom apps too * user_oidc will no longer be downloaded Signed-off-by: Thomas Lehmann <[email protected]>
…-external/ remove not defined steps variables Signed-off-by: Misha M.-Kupriyanov <[email protected]>
…-external/ split into unique steps Signed-off-by: Misha M.-Kupriyanov <[email protected]>
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Summary
TODO
Checklist