Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IONOS Header #22

Merged
merged 4 commits into from
Jul 29, 2024
Merged

IONOS Header #22

merged 4 commits into from
Jul 29, 2024

Conversation

bromiesTM
Copy link

No description provided.

@bromiesTM bromiesTM force-pushed the kh/dev/global-nav-header branch from 7c87554 to 6ed2c32 Compare July 24, 2024 12:10
@bromiesTM bromiesTM changed the title feat(header): adds ion header as submodule IONOS Header Jul 24, 2024
@bromiesTM bromiesTM force-pushed the kh/dev/global-nav-header branch 2 times, most recently from f9e5a8e to 47b27ef Compare July 24, 2024 13:40
@bromiesTM bromiesTM requested a review from printminion-co July 24, 2024 13:58
@bromiesTM bromiesTM force-pushed the kh/dev/global-nav-header branch 4 times, most recently from f3a3ea3 to 78c9c82 Compare July 25, 2024 07:15
@bromiesTM bromiesTM marked this pull request as ready for review July 25, 2024 07:17
@bromiesTM bromiesTM force-pushed the kh/dev/global-nav-header branch 3 times, most recently from bc6c0e1 to dd86779 Compare July 25, 2024 13:25
@printminion-co printminion-co force-pushed the kh/dev/global-nav-header branch from dd86779 to 74ef847 Compare July 29, 2024 09:16
printminion-co
printminion-co requested changes Jul 29, 2024
View reviewed changes
Copy link

@printminion-co printminion-co left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to also enable the theme in here IONOS-Productivity/nc-config#14

  • set submodule pointer of IONOS to merged PR14 in master

review ok if requested changes are adressed

.github/workflows/easycloud-build.yml Outdated Show resolved Hide resolved
.github/workflows/easycloud-build.yml Show resolved Hide resolved
@bromiesTM bromiesTM force-pushed the kh/dev/global-nav-header branch from 74ef847 to a8a0695 Compare July 29, 2024 12:06
@bromiesTM bromiesTM merged commit 0b40e37 into ionos-dev Jul 29, 2024
3 of 4 checks passed
@bromiesTM bromiesTM deleted the kh/dev/global-nav-header branch July 29, 2024 12:20
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 2, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@printminion-co printminion-co printminion-co requested changes

Assignees
No one assigned
Labels
feedback-requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bromiesTM @printminion-co