Mk/feat/theming add theme ionos light #36
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Benjamin Gaussorgues <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
…le29 [stable29] fix(carddav): limit vcard size
…user When connecting to a SFTP server from a SFTP storage the host key is checked against the known host keys stored in a file in the data directory of the logged in Nextcloud user. The path to the file is (indirectly) got using "OC_App::getStorage", which logs an error if called when there is no logged in user; this can happen, for example, if the storage is used from a background job or a command. Not being able to read or write the file just causes the host key check to be skipped, but it has no other consequence. Moreover, even with logged in users it is likely that the file can not be read either and the check is also skipped, as the file needs to have been manually created by an admin. Due to all that now the path to the file is directly created using a View rather than relying on "OC_App::getStorage" to prevent the unneeded error from being logged. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Signed-off-by: Richard Steinmetz <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: SebastianKrupinski <[email protected]>
…able29 [stable29] fix(theming): Also provide default image as background by absolut URL
fix(files_trashbin): Make files view registering an init script
…le29 [stable29] fix(IntegrityCheck): Ensure the check is run if no results are available
* Update `@nextcloud/dialogs` to 5.3.5 * Update `@nextcloud/capabilities` to 1.2.0 * Update `@nextcloud/sharing` to 0.2.0 `@vueuse/*` is updated to reduce duplicated dependencies as the newer libraries need newer vueuse versions, but it is compatible so nothing breaking. Signed-off-by: Ferdinand Thiessen <[email protected]>
* Removed now duplicated code Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
…ctive when shared with other Vue apps Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
…braries [stable29] fix: Update Nextcloud libraries
…le29 [stable29] fix(caldav): limit vevent size
…le29 [stable29] fix(caldav): encode calendar URIs with umlauts for activities
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
…le29 [stable29] fix: Do not log an error when connecting to SFTP without a logged in user
…le29 [stable29] fix: also use optimized getFirstNodeyIdInPath for Folder::getFirstNodeById
…le29 [stable29] fix: don't use custom certificate bundle if no customer certificates are configured
…le29 [stable29] delete background jobs by id when cleaning up
Signed-off-by: Benjamin Gaussorgues <[email protected]>
…le29 [stable29] fix: allows admin to edit global credentials
…dle redirected root Signed-off-by: Steve Mokris <[email protected]>
Co-authored-by: Kate <[email protected]> Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Daniel Kesselberg <[email protected]>
…operly Also do not use filters, filters are deprecated and will make migration to Vue 3 harder. Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Kai Henseler <[email protected]>
Signed-off-by: Kai Henseler <[email protected]>
Signed-off-by: Kai Henseler <[email protected]>
Signed-off-by: Kai Henseler <[email protected]>
Signed-off-by: Kai Henseler <[email protected]>
Signed-off-by: Kai Henseler <[email protected]>
…s/scripts) Signed-off-by: Thomas Lehmann <[email protected]>
Signed-off-by: Misha M.-Kupriyanov <[email protected]>
Signed-off-by: Misha M.-Kupriyanov <[email protected]>
Signed-off-by: Franziska Bath <[email protected]>
Signed-off-by: Kai Henseler <[email protected]>
Signed-off-by: Kai Henseler <[email protected]>
Signed-off-by: Franziska Bath <[email protected]>
Signed-off-by: Misha M.-Kupriyanov <[email protected]>
Signed-off-by: Misha M.-Kupriyanov <[email protected]>
Signed-off-by: Misha M.-Kupriyanov <[email protected]>
Signed-off-by: Franziska Bath <[email protected]>
in order to override default css vars later. regenerate autoload with composer v2.5.8 (in order to minimize changes footprint): cd apps/theming/composer/ wget https://getcomposer.org/download/2.5.8/composer.phar php composer.phar dump-autoload Signed-off-by: Misha M.-Kupriyanov <[email protected]>
Signed-off-by: Misha M.-Kupriyanov <[email protected]>
in order not to load not required css Signed-off-by: Misha M.-Kupriyanov <[email protected]>
Signed-off-by: Misha M.-Kupriyanov <[email protected]>
printminion-co
force-pushed
the
mk/feat/theming_add_theme-ionos-light
branch
from
2b99c00 to
7a13791
Compare
5 tasks
bromiesTM
requested changes
Sep 11, 2024
| @@ -0,0 +1,53 @@ | |||
| <?php | |||
There was a problem hiding this comment.
thought: we could broaden this by simply calling it a eg. ionos-theme and handle native color modes via css inside the file. By doing so, we would also enable the legacy theme based Header.
bromiesTM
reviewed
Sep 11, 2024
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
printminion-co
force-pushed
the
ionos-dev
branch
from
4768126 to
fbbdec0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TODO
Checklist