Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide Translations #76

Merged
merged 4 commits into from
Dec 19, 2024
Merged

Provide Translations #76

merged 4 commits into from
Dec 19, 2024

Conversation

fracado
Copy link

@fracado fracado commented Dec 16, 2024

As long as translations for these keys aren't provided from 'files' translations, we need this workaround to provide the translations via the 'core' themes app.

Copy link

@bromiesTM bromiesTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. We should keep an eye on Nextclouds translations to remember we have to remove this.

I will add the submodule updates to this branch once the additional translations have been provided

As long as translations for these keys aren't provided from 'files' translations, we need this workaround to provide the translations via the 'core' themes app.

Signed-off-by: Franziska Bath <[email protected]>
@bromiesTM bromiesTM force-pushed the fb/dev/add-translations branch 2 times, most recently from 103896f to 9eb7e33 Compare December 17, 2024 15:09
@bromiesTM bromiesTM changed the title IONOS(files): get sidebar quota translations from 'core' Provide Translations Dec 17, 2024
@bromiesTM bromiesTM force-pushed the fb/dev/add-translations branch from 9eb7e33 to 0957766 Compare December 19, 2024 09:55
@bromiesTM bromiesTM merged commit 369e587 into ionos-dev Dec 19, 2024
5 of 6 checks passed
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants