Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse_lists_and_dicts_from_string #112

Open
wants to merge 1 commit into
base: INTER_wip
Choose a base branch
from

Conversation

rerpha
Copy link
Contributor

@rerpha rerpha commented Feb 13, 2024

Instrument(s)

Name the instrument/group of instruments this PR is for

Story/Acceptance criteria

Give a story or list the acceptance criteria that the pull request aims to fulfill

Description of work

Add your own description of the work undertaken

Issue/Ticket Reference

If this work it tied to a ticket or issue, link it here

Tests

Describing the testing undertaken for this PR

To test

Explain how the reviewer can test the changes made e.g. what state they need to be in do the tests


Code Review

  • Is the story/acceptance criteria fulfilled?
  • Is the code of an acceptable quality?
  • Are the tests sufficient?
  • Do the changes function as described and is it robust?
  • Are the changes able to work across all intended instruments?

Final Steps

  • Are there any changes to instrument configurations required?
  • Are there any changes to instrument scripts required, e.g. change on script signature, default argument and have these been communicated?
  • Does the script need to be deployed onto the instrument?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant