Prototype Add HTJ2K TransferSyntax to GDCM #5020
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type:Infrastructure
dzenanz
approved these changes
Dec 6, 2024
Yes this should definitely go upstream. This effort was less than expected to get something functional, but there are likely details in the DICOM specs that I am not aware of that may may it more complicated for complete decoding support. |
|
Great!! |
issakomi
reviewed
Dec 12, 2024
| TSField == MPEG4AVCH264BDcompatibleHighProfileLevel4_1 | ||
| TSField == MPEG4AVCH264BDcompatibleHighProfileLevel4_1 || | ||
| TSField == HTJ2KLossless || | ||
| TSField == HTJ2KRPCLLossless |
There was a problem hiding this comment.
E.g. IsLossless() will return false for HTJ2KLossless, isn't it? Something is wrong here.
P.S. Just FYI, I don't plan to step into this stuff (I don't use GDCM / GDCMIO for my app), sorry.
AFAIK, upstream GDCM has internal OpenJPEG version 2.3, decoding of HTJ2K requires 2.5. Just FYI. |
DICOM Supplement 235 describes HTJ2K Transfer Syntax. OpenJPEG>=2.2 supports decoding HTJ2K. Update GDCM with additional HTJ2K transfer syntaxes and use existing JPEG200Codec to decode.
Clarify documentation for support compression types for writing.
Added test images from: https://www.aliza-dicom-viewer.com/download/datasets These may be a little large.
blowekamp
force-pushed
the
gdcm_htj2k
branch
from
1a79eb4 to
5568f41
Compare
|
Draft of GDCM changes submitted upstream: malaterre/GDCM#187 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #3983
PR Checklist
Refer to the ITK Software Guide for
further development details if necessary.