Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Import libLBFGS from upstream #5175

Merged
merged 5 commits into from
Jan 26, 2025
Merged

ENH: Import libLBFGS from upstream #5175

merged 5 commits into from
Jan 26, 2025

Conversation

bradking
Copy link
Member

@bradking bradking commented Jan 24, 2025 •
edited by dzenanz
Loading

It was originally imported by 7fba333, but just by copying source files.

Import the same version using our modern third-party import infrastructure.

Closes #3135.

@github-actions github-actions bot added type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots type:Enhancement Improvement of existing methods or implementation area:ThirdParty Issues affecting the ThirdParty module area:Numerics Issues affecting the Numerics module labels Jan 24, 2025
@bradking bradking mentioned this pull request Jan 24, 2025
Closed
@bradking bradking requested a review from dzenanz January 24, 2025 20:08
dzenanz
dzenanz reviewed Jan 24, 2025
View reviewed changes
Copy link
Member

@dzenanz dzenanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on a glance. Now waiting for CI to finish 😄

@blowekamp
Copy link
Member

There were a few commit since the initial import:
0402e50 COMP: remove try-compile for SSE2 detection
0ba93de BUG: Use explicit libm linking only on UNIX.
8afc60c Explicit libm linking for NrrdIO and libLBFGS.
9f187bd BUG: stdint.h missing on Visual Studio 9

Reviewing them I don't think any made substantiative changes that need to be included.

PR LGTM! Thanks!

@seanm
Copy link
Contributor

seanm commented Jan 24, 2025

0402e50 COMP: remove try-compile for SSE2 detection

That looks valuable for Universal Binaries on macOS. Anyway, will be easy to update later thanks to @bradking's work here.

@hjmjohnson hjmjohnson self-assigned this Jan 26, 2025
@hjmjohnson hjmjohnson merged commit fde014a into InsightSoftwareConsortium:master Jan 26, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzenanz dzenanz dzenanz left review comments

@hjmjohnson hjmjohnson hjmjohnson approved these changes

Assignees

@hjmjohnson hjmjohnson

Labels
area:Numerics Issues affecting the Numerics module area:ThirdParty Issues affecting the ThirdParty module type:Enhancement Improvement of existing methods or implementation type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No upstream is defined for third party /Modules/ThirdParty/libLBFGS
6 participants
@bradking @blowekamp @seanm @hjmjohnson @dzenanz @kwrobot