Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bugs #10

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Fix bugs #10

wants to merge 6 commits into from

Conversation

stighellemans
Copy link

Description

This pull request aims to fix several issues, as described in the issues section. It makes it possible to use LUCID-GAN in the edge cases and fixes some bugs of the code around the adult dataset.

It's important to mention that the folder 'illustration' only exists to illustrate the issues.

Fixes issues #6, #7, #8, #9

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
    -> Not necessary
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
    -> See illustration folder
  • New and existing unit tests pass locally with my changes
    -> Not possible since I run into some trouble installing the dependencies of Keras/Tensorflow.
  • Any dependent changes have been merged and published in downstream modules

@stighellemans
Fix bugs
87bd5d2 
Critical improvements to let LUCID-GAN work in all edge cases.
@stighellemans
Small additional changes
4ab4cd4 
Code formatted
Small docstring changes
Change to MakeFile
@stighellemans
Small change
6d042f6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndresAlgaba AndresAlgaba Awaiting requested review from AndresAlgaba AndresAlgaba is a code owner

At least 0 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stighellemans @AndresAlgaba