Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix build warnings #152

Merged
merged 1 commit into from
Aug 12, 2024
Merged

fix build warnings #152

merged 1 commit into from
Aug 12, 2024

Conversation

Nikhil-Singhal-06
Copy link
Member

Description

find_namespace_packages: Use this when entry scripts are from other packages or when there's no init.py file in the entry script location folder.
find_packages: Use this when there are no entry points or external dependencies.

Pull request checklist

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • Format and Lint checks (make check) pass locally
  • PR applies Apache 2.0 License to all code files

Pull request type

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes
  • Other (please describe)

Current behavior

Python build warnings "library is not found."

New behavior

Clean build

How to test

Colcon build

@fred-labs fred-labs self-requested a review August 12, 2024 11:23
@fred-labs fred-labs enabled auto-merge (squash) August 12, 2024 11:23
Copy link

Test Results

266 tests   251 ✅  38m 47s ⏱️
 16 suites   15 💤
 16 files      0 ❌

Results for commit 10ff437.

@fred-labs fred-labs merged commit e50339c into main Aug 12, 2024
28 checks passed
@fred-labs fred-labs deleted the fix_warnings branch August 12, 2024 11:24
fred-labs pushed a commit that referenced this pull request Aug 13, 2024
fred-labs pushed a commit that referenced this pull request Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants