-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Service_call_qos #161
Merged
Merged
Service_call_qos #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nikhil-Singhal-06
changed the title
add param to service_call and fix pylint warnings
Service_call_qos
Aug 20, 2024
Test Results275 tests 267 ✅ 36m 29s ⏱️ Results for commit 245222d. ♻️ This comment has been updated with latest results. |
fred-labs
requested changes
Aug 21, 2024
scenario_execution_ros/scenario_execution_ros/actions/ros_service_call.py
Outdated
Show resolved
Hide resolved
scenario_execution_ros/scenario_execution_ros/actions/ros_service_call.py
Outdated
Show resolved
Hide resolved
fred-labs
requested changes
Aug 22, 2024
scenario_execution_ros/scenario_execution_ros/actions/ros_action_call.py
Outdated
Show resolved
Hide resolved
fred-labs
approved these changes
Aug 22, 2024
fred-labs
pushed a commit
that referenced
this pull request
Aug 22, 2024
fmirus
pushed a commit
that referenced
this pull request
Aug 26, 2024
Co-authored-by: Nikhil <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#156
Pull request checklist
make check
) pass locallyPull request type
Current behavior
New behavior
How to test