Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix asset_topic_latency action #210

Merged
merged 4 commits into from
Oct 15, 2024
Merged

fix asset_topic_latency action #210

merged 4 commits into from
Oct 15, 2024

Conversation

Nikhil-Singhal-06
Copy link
Member

Description

Fix asset_topic_latency action

Fix issue #177

Pull request checklist

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • Format and Lint checks (make check) pass locally
  • PR applies Apache 2.0 License to all code files

Pull request type

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes
  • Other (please describe)

Current behavior

action keeps waiting for message in case topic disappears.

New behavior

action terminates if the latency condition fails.

How to test

@Nikhil-Singhal-06 Nikhil-Singhal-06 changed the title fix action fix asset_topic_latency action Oct 14, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 14, 2024 •
edited
Loading

Test Results

360 tests   352 ✅  38m 46s ⏱️
 17 suites    8 💤
 17 files      0 ❌

Results for commit 1ceb086.

♻️ This comment has been updated with latest results.

fmirus
fmirus requested changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@fmirus fmirus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Could you please add a test for the retrigger functionality?

@fmirus fmirus merged commit 80d5489 into main Oct 15, 2024
29 checks passed
@fmirus fmirus deleted the fix/assert-topic-latency branch October 15, 2024 12:06
Nikhil-Singhal-06 added a commit that referenced this pull request Oct 17, 2024
@Nikhil-Singhal-06
fix asset_topic_latency action (#210)
24f8106 
* fix action

* add support for retrigger

* add text case

* fix typo
Nikhil-Singhal-06 added a commit that referenced this pull request Oct 17, 2024
@Nikhil-Singhal-06
fix asset_topic_latency action (#210)
396185b 
* fix action

* add support for retrigger

* add text case

* fix typo
Nikhil-Singhal-06 added a commit that referenced this pull request Oct 17, 2024
@Nikhil-Singhal-06
Update jazzy latency topic (#214)
93ec1dc 
* fix asset_topic_latency action (#210)

* fix action

* add support for retrigger

* add text case

* fix typo

* add param type_check

* fix

* docs

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmirus fmirus fmirus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nikhil-Singhal-06 @fmirus