Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update assert topic latency #211

Merged
merged 4 commits into from
Oct 17, 2024
Merged

update assert topic latency #211

merged 4 commits into from
Oct 17, 2024

Conversation

Nikhil-Singhal-06
Copy link
Member

Description

Topic type check bool for action (useful in case of hidden topics)

Pull request checklist

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • Format and Lint checks (make check) pass locally
  • PR applies Apache 2.0 License to all code files

Pull request type

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes
  • Other (please describe)

Current behavior

New behavior

How to test

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 15, 2024 •
edited
Loading

Test Results

360 tests   352 ✅  46m 18s ⏱️
 17 suites    8 💤
 17 files      0 ❌

Results for commit 97eac1a.

♻️ This comment has been updated with latest results.

fmirus
fmirus previously approved these changes Oct 17, 2024
View reviewed changes
@Nikhil-Singhal-06 Nikhil-Singhal-06 enabled auto-merge (squash) October 17, 2024 14:16
@Nikhil-Singhal-06 Nikhil-Singhal-06 merged commit 8a666b5 into main Oct 17, 2024
29 checks passed
@Nikhil-Singhal-06 Nikhil-Singhal-06 deleted the update_assert_topic_latency branch October 17, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmirus fmirus fmirus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nikhil-Singhal-06 @fmirus