Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/random-functions #217

Merged
merged 9 commits into from
Nov 20, 2024
Merged

feature/random-functions #217

merged 9 commits into from
Nov 20, 2024

Conversation

Nikhil-Singhal-06
Copy link
Member

Description

random function for int and list of strings

Pull request checklist

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • Format and Lint checks (make check) pass locally
  • PR applies Apache 2.0 License to all code files

Pull request type

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes
  • Other (please describe)

Current behavior

New behavior

How to test

@Nikhil-Singhal-06 Nikhil-Singhal-06 changed the title add random int and random list feature/random-functions Oct 18, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 18, 2024 •
edited
Loading

Test Results

362 tests   354 ✅  38m 18s ⏱️
 17 suites    8 💤
 17 files      0 ❌

Results for commit 4358ca3.

♻️ This comment has been updated with latest results.

fred-labs
fred-labs requested changes Oct 20, 2024
View reviewed changes
Copy link
Contributor

@fred-labs fred-labs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add test

fmirus
fmirus previously approved these changes Oct 24, 2024
View reviewed changes
@Nikhil-Singhal-06 Nikhil-Singhal-06 enabled auto-merge (squash) October 24, 2024 16:28
@Nikhil-Singhal-06 Nikhil-Singhal-06 merged commit 8b187dc into main Nov 20, 2024
29 checks passed
@Nikhil-Singhal-06 Nikhil-Singhal-06 deleted the feature/random-functions branch November 20, 2024 08:01
fred-labs pushed a commit that referenced this pull request Nov 20, 2024
@Nikhil-Singhal-06 @fred-labs
feature/random-functions (#217)
99d7005 
* add random int and random list

* format

* add unittest

* generic method

* format
fred-labs pushed a commit that referenced this pull request Nov 20, 2024
@Nikhil-Singhal-06 @fred-labs
feature/random-functions (#217)
29503d8 
* add random int and random list

* format

* add unittest

* generic method

* format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fred-labs fred-labs fred-labs approved these changes

@fmirus fmirus fmirus left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nikhil-Singhal-06 @fmirus @fred-labs