Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spawn actor relative to base_link on the map #86

Closed
wants to merge 3 commits into from
Closed

spawn actor relative to base_link on the map #86

wants to merge 3 commits into from

Conversation

georgepos
Copy link
Contributor

Description

Added action for spawning an object in front of base_link on the map

Pull request checklist

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • Format and Lint checks (make check) pass locally
  • PR applies Apache 2.0 License to all code files

Pull request type

  • Bugfix
  • Feature

Current behavior

no action to spawn object relative to the base_link of the robot

New behavior

action created for spawning an object in front of base_link on map

How to test

        box.relative_spawn(
            base_link_offset_min: 0.5,
            base_link_offset_max: 1.5,
            model: 'example_simulation://models/box.sdf',
            world_name: 'maze')

georgepos added 3 commits May 23, 2024 16:21
@georgepos
doubled box size, sometimes it was not picked up as object
94aa358 
Signed-off-by: George Postolache <[email protected]>
@georgepos
small updates for odometry_distance_traveled
e653c2f 
	updated setup.py to get OdometryDistanceTraveled from differential_drive_robot.odometry_distance_traveled
	updated differential_drive_robot.odometry_distance_traveled to use namespace_override instead of namespace
	updated some feedback_messages from OdometryDistanceTraveled to convert self.distance_expected to float since sometimes it is not float
	initialised self.distance_traveled with 0.0 instead of 0.

Signed-off-by: George Postolache <[email protected]>
@georgepos
added gazebo_relative_spawn_actor action
015536f 
Signed-off-by: George Postolache <[email protected]>
@georgepos georgepos marked this pull request as draft May 23, 2024 14:39
@fmirus fmirus mentioned this pull request May 27, 2024
Merged
7 tasks
@fmirus
Copy link
Contributor

fmirus commented Jun 21, 2024

closed in favor of #87

@fmirus fmirus closed this Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@georgepos @fmirus