UTxO-HD targeting main #6068
Open
UTxO-HD targeting main #6068
+1,498
−493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasagredo
force-pushed
the
utxo-hd-main
branch
4 times, most recently
from
ea5ecaa to
af2e523
Compare
Jimbo4350
approved these changes
Jan 10, 2025
| npcTestBabbageHardForkAtEpoch, | ||
| npcTestBabbageHardForkAtVersion, |
| Nothing -> Consensus.TriggerHardForkAtVersion | ||
| (maybe 4 fromIntegral npcTestMaryHardForkAtVersion) | ||
| Just epochNo -> Consensus.TriggerHardForkAtEpoch epochNo | ||
| Nothing -> Consensus.CardanoTriggerHardForkAtDefaultVersion |
There was a problem hiding this comment.
We can abstract this out as a function but this is not a blocker.
| "Praos" | ||
| -> pure $ NodeConsensusMode PraosMode | ||
| _ -> fail "Parsing NodeConsensusMode failed: can be either 'Genesis' or 'Praos'" | ||
| parseJSON _ = fail "Parsing NodeConsensusMode failed" |
There was a problem hiding this comment.
Returning the unexpected JSON will help with debugging.
| @@ -302,20 +299,9 @@ findAllUtxos | |||
| -> ShelleyBasedEra era | |||
| -> m (Map TxIn (TxOut CtxUTxO era)) | |||
| findAllUtxos epochStateView sbe = withFrozenCallStack $ do | |||
| AnyNewEpochState sbe' newEpochState <- getEpochState epochStateView | |||
| AnyNewEpochState sbe' _ tbs <- getEpochState epochStateView | |||
There was a problem hiding this comment.
cardano-testnet/test/cardano-testnet-test/Cardano/Testnet/Test/Cli/Query.hs
Show resolved
Hide resolved
jasagredo
force-pushed
the
utxo-hd-main
branch
3 times, most recently
from
fcd6d20 to
f99dd7f
Compare
jasagredo
force-pushed
the
utxo-hd-main
branch
2 times, most recently
from
4f66f3a to
6844b37
Compare
carbolymer
approved these changes
Jan 22, 2025
Give more context for incompatibility between bootstrap peers and new Genesis syncing mechanism.
jasagredo
force-pushed
the
utxo-hd-main
branch
from
6844b37 to
0074be1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements the changes required for UTxO-HD Consensus feature. See the documentation for an extensive explanation on what changed and the implications.
Checklist
See Runnings tests for more details
CHANGELOG.mdfor affected package.cabalfiles are updatedhlint. See.github/workflows/check-hlint.ymlto get thehlintversionstylish-haskell. See.github/workflows/stylish-haskell.ymlto get thestylish-haskellversionghc-8.10.7andghc-9.2.7