Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add _≥_ and _>_ to HasPreorder and ℚ instance #326

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Add _≥_ and _>_ to HasPreorder and ℚ instance #326

merged 1 commit into from
Dec 12, 2023

Conversation

WhatisRT
Copy link
Collaborator

@WhatisRT WhatisRT commented Dec 7, 2023

Description

This popped up while I reviewed #309, which adds a module qualifier to _≥_. This won't be necessary after this PR.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • Code is formatted according to CONTRIBUTING.md
  • Self-reviewed the diff

@WhatisRT WhatisRT mentioned this pull request Dec 7, 2023
Merged
@WhatisRT WhatisRT force-pushed the andre/has-ord-greater branch from 0746be3 to 9db1f6e Compare December 8, 2023 13:29
omelkonian
omelkonian approved these changes Dec 12, 2023
View reviewed changes
Copy link
Collaborator

@omelkonian omelkonian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

src/Interface/HasOrder/Instance.agda Show resolved Hide resolved
@WhatisRT WhatisRT force-pushed the andre/has-ord-greater branch from 9db1f6e to 930c2a8 Compare December 12, 2023 15:23
@WhatisRT WhatisRT merged commit e91c35c into master Dec 12, 2023
2 of 3 checks passed
@WhatisRT WhatisRT deleted the andre/has-ord-greater branch December 12, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omelkonian omelkonian omelkonian approved these changes

@williamdemeo williamdemeo Awaiting requested review from williamdemeo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WhatisRT @omelkonian