Fix bug when trying to create FileExtension

Creation was only possible from lowercase extensions. This patch makes it possible to create from lowercase or uppercase.
Intervention · Jan 17, 2025 · 0cd29e6 · 0cd29e6
1 parent f701421
commit 0cd29e6
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/src/Encoders/FileExtensionEncoder.php b/src/Encoders/FileExtensionEncoder.php
@@ -61,7 +61,7 @@ protected function encoderByFileExtension(null|string|FileExtension $extension):
         }
 
         try {
-            $extension = is_string($extension) ? FileExtension::from($extension) : $extension;
+            $extension = is_string($extension) ? FileExtension::from(strtolower($extension)) : $extension;
         } catch (Error) {
             throw new EncoderException('No encoder found for file extension (' . $extension . ').');
         }

diff --git a/tests/Unit/Encoders/FileExtensionEncoderTest.php b/tests/Unit/Encoders/FileExtensionEncoderTest.php
@@ -67,6 +67,17 @@ public static function targetEncoderProvider(): Generator
         yield ['tif', TiffEncoder::class];
         yield ['jp2', Jpeg2000Encoder::class];
         yield ['heic', HeicEncoder::class];
+        yield ['WEBP', WebpEncoder::class];
+        yield ['AVIF', AvifEncoder::class];
+        yield ['JPEG', JpegEncoder::class];
+        yield ['JPG', JpegEncoder::class];
+        yield ['BMP', BmpEncoder::class];
+        yield ['GIF', GifEncoder::class];
+        yield ['PNG', PngEncoder::class];
+        yield ['TIFF', TiffEncoder::class];
+        yield ['TIF', TiffEncoder::class];
+        yield ['JP2', Jpeg2000Encoder::class];
+        yield ['HEIC', HeicEncoder::class];
         yield [FileExtension::WEBP, WebpEncoder::class];
         yield [FileExtension::AVIF, AvifEncoder::class];
         yield [FileExtension::JPG, JpegEncoder::class];