Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oai-pmh mods representation #52

Closed
wants to merge 2 commits into from

Conversation

Natkeeran
Copy link
Contributor

This PR provides a MODS representation. This is done by powering a twig powered OAI-PMH Record view powered by a Drupal view consisting of a given Repository Item metadata.

Composer Changes

Config Changes

  • rest_oai_pmh.settings - module config, sets up MODS
  • views.view.oai_pmh_item_data - provides the metadata that powers the twig
  • search_api.index.default_solr_index - some additional fields such as the ID needed for the above view
  • views.view.oai_pmh_item_links - sets up the block needed to show the link
  • context.context.display_oai_pmh_item_links - places the block

Additional Notes

  • Some of the other changes to the composer are due to an issue in building isle-dc.
  • When sync from isle-dc, some configs are being updated with ip or domain, I am not sure how to avoid this!

context_mapping:
node: '@node.node_route_context:node'
bundles:
islandora_object: islandora_object
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could change this to use "if node is an Islandora object" to be less dependent on the content type.

@@ -3,4 +3,4 @@ _core:
icon_base_uri: 'public://media-icons/generic'
iframe_domain: ''
oembed_providers_url: 'https://oembed.com/providers.json'
standalone_url: false
standalone_url: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unset this - it's being set by Isle-DC using code in buildkit. Islandora-Devops/isle-dc#326

@Natkeeran
Copy link
Contributor Author

@rosiel

I've changed the context as suggested, and also cleaned up the configs that gets into the PR for this feature. It was easier to create another PR: #61.

@Natkeeran Natkeeran closed this Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants