Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codeserver docs + ubuntu 24 integration tests #71

Merged
merged 6 commits into from
Nov 12, 2024

Conversation

joecorall
Copy link
Contributor

@joecorall joecorall commented Nov 6, 2024

Closes #46

@joecorall joecorall changed the title Add workaround for SSH_AUTH_SOCK in integration test Codeserver docs + ubuntu 24 integration tests Nov 7, 2024
@joecorall joecorall marked this pull request as ready for review November 7, 2024 09:22
@nigelgbanks
Copy link
Contributor

This might fix the test failures. #74

@joecorall
Copy link
Contributor Author

This might fix the test failures. #74

I feel like the GitHub runner is having some resource issue effecting this. I am going to try creating a custom runner to see if that resolves this issue.

@joecorall joecorall force-pushed the integration-test-auth-sock branch from 2c1b301 to 457620d Compare November 12, 2024 13:02
@joecorall joecorall marked this pull request as draft November 12, 2024 13:15
@nigelgbanks
Copy link
Contributor

@joecorall I see that this is still in draft, do you want me to hold off on merging it?

@joecorall joecorall marked this pull request as ready for review November 12, 2024 17:25
@joecorall
Copy link
Contributor Author

joecorall commented Nov 12, 2024

Great work on #76 @nigelgbanks. I put this in draft this morning knowing there was still something going on. With your fix I think we're good to merge!

@nigelgbanks nigelgbanks merged commit 612df53 into main Nov 12, 2024
4 checks passed
@nigelgbanks nigelgbanks deleted the integration-test-auth-sock branch November 12, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

setup.sh failing on Ubuntu 24.04
2 participants