Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add table of central wavenumber to iasi converter #1351

Closed
wants to merge 8 commits into from

Conversation

smaticka
Copy link
Contributor

@smaticka smaticka commented Sep 1, 2023

Description

Rather than pulling central wavenumber per experiment in the skylab yaml, we are adding a static table of central wavenumber values to be exported during the ioda convertion.

Need to add an 'assign method' in ioda-converter yaml for iasi that looks up a table of values.

Issue(s) addressed

Resolves #1313

@smaticka smaticka added the OBS OBS processing, UFO label Sep 1, 2023
@smaticka smaticka self-assigned this Sep 1, 2023
test/testinput/bufr_ncep_mtiasi.yaml Outdated Show resolved Hide resolved
@rmclaren
Copy link
Contributor

rmclaren commented Sep 2, 2023

If you use gettab on this BUFR file you get the following mnemonics:

gettab test/testinput/gdas.t12z.mtiasi.tm00.bufr_d | grep WAVE

| WVNM     | 006029 | WAVE NUMBER                                              |
| LOGRCW   | 025076 | LOG-10 OF (TEMPERATURE-RADIANCE CENTRAL WAVENUMBER)      |

but when you run print_queries.x test/testinput/gdas.t12z.mtiasi.tm00.bufr_d you find out these mnemonics are not available in the test dataset...

You can add a global like you tried, but I'm not sure this this is the right answer as I'm guessing these wavenumbers will be different for different IASI files (?). For more flexibility you could read the data using the python API.

@smaticka
Copy link
Contributor Author

smaticka commented Sep 5, 2023

If you use gettab on this BUFR file you get the following mnemonics:

gettab test/testinput/gdas.t12z.mtiasi.tm00.bufr_d | grep WAVE

| WVNM     | 006029 | WAVE NUMBER                                              |
| LOGRCW   | 025076 | LOG-10 OF (TEMPERATURE-RADIANCE CENTRAL WAVENUMBER)      |

but when you run print_queries.x test/testinput/gdas.t12z.mtiasi.tm00.bufr_d you find out these mnemonics are not available in the test dataset...

You can add a global like you tried, but I'm not sure this this is the right answer as I'm guessing these wavenumbers will be different for different IASI files (?). For more flexibility you could read the data using the python API.

Thanks for checking this @rmclaren. The input test data file hasn't been updated yet, but was the next planned task. Just wanted to get the draft created for conversation on the table entry to begin. I'll work on the new file next.

@rmclaren
Copy link
Contributor

rmclaren commented Sep 5, 2023

Cool. I should probably update the print_queries.x output to show the description information so that you don't need to switch back and forth... Please be aware that the gettab output often does not really reflect the data in the file (lists subsets that don't exists, often does not list subsets actually in the file). print_queries.x will show you whats actually available in the file.

@smaticka
Copy link
Contributor Author

smaticka commented Sep 5, 2023

Cool. I should probably update the print_queries.x output to show the description information so that you don't need to switch back and forth... Please be aware that the gettab output often does not really reflect the data in the file (lists subsets that don't exists, often does not list subsets actually in the file). print_queries.x will show you whats actually available in the file.

Gotcha. that makes sense then b/c WVNM was still in the output of gettab, but it's not in the print_queries.x output.

Copy link
Contributor

@fabiolrdiniz fabiolrdiniz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on it, @smaticka. I suspect your code will have a global attribute with the sensorCentralWavenumber values. However, I believe what you are looking for is a MetaData channel-dimensioned variable with those values (MetaData/sensorCentralWavenumber(Channel)).

@rmclaren, is there a way of passing a float vector straight to an IODA variable? We know she can do that through a filter when using this file (UFO level), but I believe people would like to have it added at this stage. The solution via YAML at runtime opens the door to have different sensorCentralWavenumber though (which was a concern above).

@@ -6,7 +6,7 @@
observations:
- obs space:
name: bufr
obsdatain: "./testinput/gdas.t12z.mtiasi.tm00.bufr_d"
obsdatain: "./testinput/gdas.mtiasi.t00z.20220216.bufr"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know why the original file doesn't work? Please, notice that your added file (test/testinput/gdas.mtiasi.t00z.20220216.bufr) has 779 MB, it's too large. I'd revert it to use the original file or reduce the new one.

Suggested change
obsdatain: "./testinput/gdas.mtiasi.t00z.20220216.bufr"
obsdatain: "./testinput/gdas.t12z.mtiasi.tm00.bufr_d"

@BenjaminRuston BenjaminRuston changed the title Add table of central wavenumber to iasia converter Add table of central wavenumber to iasi converter Sep 8, 2023
@BenjaminRuston
Copy link
Collaborator

@smaticka this likely will be moved to future work as updates to the converter are needed to make this happen. Should plan this either with Ron as part for bufr2ioda.x,,, or with SteveH so yaml can be used to write MetaData

@BenjaminRuston
Copy link
Collaborator

in short we may want to close this

@smaticka smaticka closed this Sep 11, 2023
@smaticka
Copy link
Contributor Author

Closing to reopen later once 2d ability is allowed for MetaData

@smaticka smaticka reopened this Nov 3, 2023
@BenjaminRuston
Copy link
Collaborator

@smaticka yes this is so confusing, but yes this ioda-converter PR can likely close again

we'll use the table of wavenumbers in a ufo instrumentTests ctest with a reduced ioda file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OBS OBS processing, UFO
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup of plain old radiance vs spectral radiance vs scaled radiance
5 participants