Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] refactor: api 로직과 커스텀 훅 분리 #38

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from

Conversation

SangWoo9734
Copy link
Collaborator

📝 작업 내용

  • api 로직에 포함되어 있던 서버 데이터 fetching 관련 커스텀 훅을 hooks/serverStateHooks 하위 경로의 별도 파일로 분리

@SangWoo9734 SangWoo9734 self-assigned this Jan 9, 2025
@SangWoo9734 SangWoo9734 requested a review from dahyeo-n January 9, 2025 07:50
Copy link

vercel bot commented Jan 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
momentia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2025 8:26am

@github-actions github-actions bot added refactor 코드 리팩토링, 주석 삭제 bug labels Jan 9, 2025
Copy link
Member

@dahyeo-n dahyeo-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인하고 approve 했습니다!
제가 작성해 둔 참고사항 코멘트 하나만 확인하신 뒤 merge 해주시기 바랍니다 :)

@@ -17,6 +16,7 @@ import {
SIGNIN_ERROR_MESSAGE,
} from '@/constants/errorMessage';
import ROUTE from '@/constants/routes';
import usePostSignUp from '@/hooks/serverStateHooks/usePostSignUp';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아 상우님 import sort 때문에 PR 올리시기 전에 pnpm fix 명령어 입력해서 정렬 맞춰주세여

제가 pnpm fix 하면 모든 파일의 import 정렬되도록 명령어 넣어놨어요. 참고 바랍니다!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug refactor 코드 리팩토링, 주석 삭제
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants