-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] refactor: api 로직과 커스텀 훅 분리 #38
base: dev
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
확인하고 approve 했습니다!
제가 작성해 둔 참고사항 코멘트 하나만 확인하신 뒤 merge 해주시기 바랍니다 :)
@@ -17,6 +16,7 @@ import { | |||
SIGNIN_ERROR_MESSAGE, | |||
} from '@/constants/errorMessage'; | |||
import ROUTE from '@/constants/routes'; | |||
import usePostSignUp from '@/hooks/serverStateHooks/usePostSignUp'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아 상우님 import
sort 때문에 PR 올리시기 전에 pnpm fix
명령어 입력해서 정렬 맞춰주세여
제가 pnpm fix
하면 모든 파일의 import
정렬되도록 명령어 넣어놨어요. 참고 바랍니다!
📝 작업 내용
hooks/serverStateHooks
하위 경로의 별도 파일로 분리