Fixed restClient.V5Api.SubAccount.EditSubAccountApiKeyAsync parameter…

…s not getting send
JKorf · Dec 23, 2024 · 20b506b · 20b506b
1 parent 650eb65
commit 20b506b
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 10 deletions.
diff --git a/ByBit.Net/Clients/V5/BybitRestClientApiSubAccounts.cs b/ByBit.Net/Clients/V5/BybitRestClientApiSubAccounts.cs
@@ -151,16 +151,28 @@ public async Task<WebCallResult<BybitApiKeyInfo>> EditSubAccountApiKeyAsync(
             parameters.AddOptionalParameter("ips", ipRestrictions);
 
             var permissions = new Dictionary<string, List<string>>();
-            AddPermission(permissions, permissionContractTradeOrder, "ContractTrade", "Order");
-            AddPermission(permissions, permissionContractTradePosition, "ContractTrade", "Position");
-            AddPermission(permissions, permissionSpotTrade, "Spot", "SpotTrade");
-            AddPermission(permissions, permissionWalletTransfer, "Wallet", "AccountTransfer");
-            AddPermission(permissions, permissionWalletSubAccountTransfer, "Wallet", "SubMemberTransferList");
-            AddPermission(permissions, permissionOptionsTrade, "Options", "OptionsTrade");
-            AddPermission(permissions, permissionCopyTrading, "CopyTrading", "CopyTrading");
-            AddPermission(permissions, permissionExchangeHistory, "Exchange", "ExchangeHistory");
+            EditPermission(permissions, permissionContractTradeOrder, "ContractTrade", "Order");
+            EditPermission(permissions, permissionContractTradePosition, "ContractTrade", "Position");
+            EditPermission(permissions, permissionSpotTrade, "Spot", "SpotTrade");
+            EditPermission(permissions, permissionWalletTransfer, "Wallet", "AccountTransfer");
+            EditPermission(permissions, permissionWalletSubAccountTransfer, "Wallet", "SubMemberTransferList");
+            EditPermission(permissions, permissionOptionsTrade, "Options", "OptionsTrade");
+            EditPermission(permissions, permissionCopyTrading, "CopyTrading", "CopyTrading");
+            EditPermission(permissions, permissionExchangeHistory, "Exchange", "ExchangeHistory");
             parameters.Add("permissions", permissions);
-            return await _baseClient.SendRequestAsync<BybitApiKeyInfo>(_baseClient.GetUrl("v5/user/update-sub-api"), HttpMethod.Post, ct, null, true).ConfigureAwait(false);
+            return await _baseClient.SendRequestAsync<BybitApiKeyInfo>(_baseClient.GetUrl("v5/user/update-sub-api"), HttpMethod.Post, ct, parameters, true).ConfigureAwait(false);
+        }
+
+        private void EditPermission(Dictionary<string, List<string>> dict, bool? hasPermission, string key, string value)
+        {
+            if (hasPermission == null)
+                return;
+
+            if (!dict.ContainsKey(key))
+                dict[key] = new List<string>();
+
+            if (hasPermission == true)
+                dict[key].Add(value);
         }
         #endregion
 

diff --git a/ByBit.Net/Interfaces/Clients/V5/IBybitRestClientApiSubAccounts.cs b/ByBit.Net/Interfaces/Clients/V5/IBybitRestClientApiSubAccounts.cs
@@ -68,7 +68,7 @@ Task<WebCallResult<BybitApiKeyInfo>> CreateSubAccountApiKeyAsync(
         Task<WebCallResult<List<BybitSubAccount>>> GetSubAccountsAsync(CancellationToken ct = default);
 
         /// <summary>
-        /// Edit API key
+        /// Edit API key. Note that permissions starting with the same topic (for example `permissionContractTradeOrder` and `permissionContractTradePosition` or `permissionWalletTransfer` and `permissionWalletSubAccountTransfer`) can not be adjusted separately and should both be set when changing one of the values.
         /// <para><a href="https://bybit-exchange.github.io/docs/v5/user/modify-sub-apikey" /></para>
         /// </summary>
         /// <param name="apiKey">Api key, should be passed if editing from Master account, should be null if editing own API key from sub account</param>