Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ARM64 support, unify encoding, and upgrade to WiX 5 #260

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

Amrsatrio
Copy link
Contributor

Three things in this PR:

  1. I've added native ARM64 support so that this is no longer emulated on Snapdragon laptops (which I'm daily driving).
  2. I've forced the compiler to interpret the files as UTF-8 encoding.
    I have my development environment set to Japanese locale, and due to no BOM in the source files, the parsing of restart keywords JSON array fails because cl.exe interpreted them as code page 932.
  3. Upgraded to WiX 5 because WiX 3 is no longer maintained. I used the HeatWave VS2022 extension to perform the conversion. This is the first time I'm touching WiX so apologies for any mistakes.

Tested:

a. Installation
b. Uninstallation
c. TV test function (turns off + turns on after 5s successfully)

Todo:

  • Update CI

@JPersson77 JPersson77 marked this pull request as ready for review January 6, 2025 19:26
Copy link
Owner

@JPersson77 JPersson77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code approved

@JPersson77 JPersson77 merged commit 813ed9d into JPersson77:master Jan 21, 2025
@JPersson77
Copy link
Owner

Thanks for the useful PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants