Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build RichText segments without markdown parsing #121

Merged
merged 3 commits into from
Oct 17, 2023

Conversation

GalihFajar
Copy link

Description:

Addresses issue #117

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

dependabot bot and others added 3 commits October 14, 2023 00:19
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.14.0 to 0.17.0.
- [Commits](golang/net@v0.14.0...v0.17.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
…g.org/x/net-0.17.0

Bump golang.org/x/net from 0.14.0 to 0.17.0
@GalihFajar GalihFajar changed the base branch from main to next October 17, 2023 03:52
Copy link
Owner

@Jacalz Jacalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This looks good so approved :)

FYI: Because you based the branch on main, there are two commits in the PR that were on main but not on next. I wanted those on next either way so it is fine this time :)

@Jacalz Jacalz merged commit 3149ca1 into Jacalz:next Oct 17, 2023
4 checks passed
@GalihFajar
Copy link
Author

@Jacalz Thanks, my bad I just realized which branch to target midways.

@Jacalz
Copy link
Owner

Jacalz commented Oct 17, 2023

It is a common problem on GitHub. I wish we could set a default branch for PR targets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants