V0.3.3 #37
Merged
V0.3.3 #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- change rule to 93 limit to not be inclusive - revert prior to making fs loading changes to instead investigate extending the bypass flag for stdin
testing read buffer implementation to increase reading speed of large files and seeing how memory could be optimized in scenarios
after testing between 1 GB and 5 GB there doesn't seem to be a lot of difference past 2GB estimated
Seems like the unused buffer is freed pretty quickly so having more only helps more with large files. This implementation is faster than the original in all cases just fine-tuning the default buffer size at either 2GB or 4GB. Leaning towards 4GB because there have been examples of almost 30 second faster times than the 2GB buffer and I would expect users to use -f on a system with at least 8 GB of RAM.
added a new mode called regram
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-freading of 4 GB. This means that when using-fa large 4 GB buffer will be allocated and reused for loading large files.-fallocates this buffer and I would imagine users would have ~ 8 GB at minimum.regram. This mode takes in sentences similar to-uand "regrams" them into strings with a given number of words.