Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): refresh agama lab quick start guide with respect to the latest Agama Lab version #10426

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

fix(docs): refresh agama lab quick start guide with respect to the latest Agama Lab version #10426

wants to merge 23 commits into from

Conversation

ossdhaval
Copy link
Contributor

Prepare

Description

Target issue

closes #issue-number-here

Implementation Details

Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

Please check the below before submitting your PR. The PR will not be merged if there are no commits that start with docs: to indicate documentation changes or if the below checklist is not selected.

  • I confirm that there is no impact on the docs due to the code changes in this PR.

@ossdhaval
docs: update agamalab quick start
cd3205f 
Signed-off-by: ossdhaval <[email protected]>
@ossdhaval
docs: update the agamalab quick start guide
3be01e5 
Signed-off-by: ossdhaval <[email protected]>
@ossdhaval
docs: update agamalab quick start guide
a61f259 
Signed-off-by: ossdhaval <[email protected]>
@ossdhaval
docs: update agama-lab quick start guide
1796008 
Signed-off-by: ossdhaval <[email protected]>
@ossdhaval
docs: update agama-lab quick start guide
882e346 
Signed-off-by: ossdhaval <[email protected]>
@ossdhaval
docs: add tarp test section in quick start guide
2d1822a 
Signed-off-by: ossdhaval <[email protected]>
@ossdhaval
fix(docs): improve wording
4840a60 
Signed-off-by: ossdhaval <[email protected]>
@ossdhaval
refactor(docs): update agama quick start guide
3acdf0e 
Signed-off-by: ossdhaval <[email protected]>
@ossdhaval
fix(docs): agama quick-start guide
c461ff4 
Signed-off-by: ossdhaval <[email protected]>
@ossdhaval ossdhaval self-assigned this Dec 16, 2024
@mo-auto mo-auto added area-documentation Documentation needs to change as part of issue or PR comp-agama Touching folder /agama comp-docs Touching folder /docs kind-bug Issue or PR is a bug in existing functionality labels Dec 16, 2024
SafinWasi
SafinWasi requested changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@SafinWasi SafinWasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs changes, lots of links point to private assets.

docs/janssen-server/developer/agama/quick-start-using-agama-lab.md Outdated Show resolved Hide resolved
docs/janssen-server/developer/agama/quick-start-using-agama-lab.md Outdated Show resolved Hide resolved
docs/janssen-server/developer/agama/quick-start-using-agama-lab.md Outdated Show resolved Hide resolved
docs/janssen-server/developer/agama/quick-start-using-agama-lab.md Outdated Show resolved Hide resolved
docs/janssen-server/developer/agama/quick-start-using-agama-lab.md Outdated Show resolved Hide resolved
docs/janssen-server/developer/agama/quick-start-using-agama-lab.md Outdated Show resolved Hide resolved
docs/assets/agamalab-flow-passwd-edit-assignment-uid.png Outdated Show resolved Hide resolved
docs/assets/agamalab-flow-passwd-edit-cdiutil-instance.png Outdated Show resolved Hide resolved
docs/janssen-server/developer/agama/quick-start-using-agama-lab.md Outdated Show resolved Hide resolved
docs/janssen-server/developer/agama/quick-start-using-agama-lab.md Show resolved Hide resolved
@ossdhaval
fix(docs): further edits
bbf379c 
Signed-off-by: ossdhaval <[email protected]>
@dryrunsecurity DryRunSecurity
Copy link

dryrunsecurity bot commented Dec 23, 2024 •
edited
Loading

DryRun Security Summary

There are no code changes or files modified in the provided text, so no summary or review can be generated.

Expand for full summary

Summary:

There are no code changes provided in the input, so I don't have any specific code changes to review or summarize. As an application security engineer, I would typically review any code changes in a pull request to ensure they do not introduce any security vulnerabilities or unintended consequences. Without any code changes to analyze, I don't have any specific security-related observations to provide. However, I'm ready to review any future code changes that may be submitted.

Files Changed:

There are no files changed in the provided input.

Code Analysis

We ran 9 analyzers against 30 files and 0 analyzers had findings. 9 analyzers had no findings.

View PR in the DryRun Dashboard.

@moabu moabu force-pushed the docs-quick-start-using-agama-lab branch from 330f0c1 to 8b3fb2c Compare December 26, 2024 19:25
@moabu moabu force-pushed the docs-quick-start-using-agama-lab branch from 8b3fb2c to bbf379c Compare December 27, 2024 04:55
SafinWasi
SafinWasi requested changes Dec 27, 2024
View reviewed changes
Copy link
Contributor

@SafinWasi SafinWasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some errors are still not fixed.

docs/assets/agamalab-flow-passwd-edit-cdiutil-instance.png Outdated Show resolved Hide resolved
docs/assets/agamalab-flow-passwd-edit-assignment-uid.png Outdated Show resolved Hide resolved
docs/assets/agamalab-flow-passwd-edit-fail-finish.png Outdated Show resolved Hide resolved
docs/janssen-server/developer/agama/quick-start-using-agama-lab.md Outdated Show resolved Hide resolved
docs/janssen-server/developer/agama/quick-start-using-agama-lab.md Outdated Show resolved Hide resolved
docs/janssen-server/developer/agama/quick-start-using-agama-lab.md Outdated Show resolved Hide resolved
docs/janssen-server/developer/agama/quick-start-using-agama-lab.md Outdated Show resolved Hide resolved
docs/janssen-server/developer/agama/quick-start-using-agama-lab.md Show resolved Hide resolved
jgomer2001
jgomer2001 requested changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@jgomer2001 jgomer2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be io.jans.as.server.service.AuthenticationService

@ossdhaval
Copy link
Contributor Author

should be io.jans.as.server.service.AuthenticationService

Thank you for pointing this out. I tried many different things, not realising that this was the issue. 🤦‍♂️ 🤝 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SafinWasi SafinWasi SafinWasi requested changes

@jgomer2001 jgomer2001 jgomer2001 requested changes

@duttarnab duttarnab Awaiting requested review from duttarnab

@yurem yurem Awaiting requested review from yurem

@yuriyz yuriyz Awaiting requested review from yuriyz

@yuriyzz yuriyzz Awaiting requested review from yuriyzz

@moabu moabu Awaiting requested review from moabu

@iromli iromli Awaiting requested review from iromli

Requested changes must be addressed to merge this pull request.

Assignees

@ossdhaval ossdhaval

Labels
area-documentation Documentation needs to change as part of issue or PR comp-agama Touching folder /agama comp-docs Touching folder /docs kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ossdhaval @jgomer2001 @SafinWasi @mo-auto