Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(jans-cedarling): add WASM bindings for Cedarling #10542

Open
wants to merge 47 commits into
base: main
Choose a base branch
from
Open

feat(jans-cedarling): add WASM bindings for Cedarling #10542

wants to merge 47 commits into from

Conversation

olehbozhok
Copy link
Contributor

Prepare

Description

Target issue

link

closes #10013

Implementation Details

  • Add WASM binding
  • update memory log interface to return JSON and implement to WASM binding
  • fix generation UUD7 for logging, created own function that use time from chrono, std time cause panic
  • add unit test to work in browser
  • implement simple html page that execute Cedarling in browser

Problems that should be fixed in future

  • Some JSON logs entities serialize to {} empty JSON struct. It reproduces only in WASM.

Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

Please check the below before submitting your PR. The PR will not be merged if there are no commits that start with docs: to indicate documentation changes or if the below checklist is not selected.

  • I confirm that there is no impact on the docs due to the code changes in this PR.

@olehbozhok
chore(jans-cedarling): rebase to main
5089a64 
Signed-off-by: Oleh Bohzok <[email protected]>
@olehbozhok
chore(jans-cedarling): fix monotonic uuid creation
94d9c0e 
Signed-off-by: Oleh Bohzok <[email protected]>
@olehbozhok
chore(jans-cedarling): fix generating uuid7 using generator defined i…
f899d4a 
…n the static variable

Signed-off-by: Oleh Bohzok <[email protected]>
@olehbozhok
chore(jans-cedarling): update LogStorage trait to return `serde_jso…
15fc408 
…n::Value` as result

Signed-off-by: Oleh Bohzok <[email protected]>
@olehbozhok
feat(jans-cedarling): add std log write log to browser console.
03e85af 
Signed-off-by: Oleh Bohzok <[email protected]>
@olehbozhok
chore(jans-cedarling): apply cargo fmt
b07f267 
Signed-off-by: Oleh Bohzok <[email protected]>
@olehbozhok
test(jans-cedarling): add WASM test to run cedarling
c53d49b 
Signed-off-by: Oleh Bohzok <[email protected]>
@olehbozhok
feat(jans-cedarling): add memory log to WASM API
54f6291 
Signed-off-by: Oleh Bohzok <[email protected]>
@olehbozhok
chore(jans-cedarling): remove conditional compiling for WASM,
0a3f195 
it allows to catch some errors when made changes on different platforms

Signed-off-by: Oleh Bohzok <[email protected]>
@olehbozhok
chore(jans-cedarling): improve doc message for memory log interface
1b39cc3 
Signed-off-by: Oleh Bohzok <[email protected]>
@olehbozhok
test(jans-cedarling): add test_memory_log_interface
dcce0b2 
Signed-off-by: Oleh Bohzok <[email protected]>
@olehbozhok
feat(jans-cedarling): implement html page with cedarling usage
6d0761b 
Signed-off-by: Oleh Bohzok <[email protected]>
@olehbozhok
chore(jans-cedarling): remove println
d7a04f8 
Signed-off-by: Oleh Bohzok <[email protected]>
@olehbozhok
chore(jans-cedarling): fix clippy issue
8ee1915 
Signed-off-by: Oleh Bohzok <[email protected]>
@olehbozhok
chore(jans-cedarling): add to Cargo.toml license and description
328da64 
Signed-off-by: Oleh Bohzok <[email protected]>
@olehbozhok olehbozhok requested a review from moabu as a code owner January 2, 2025 20:13
@mo-auto mo-auto added area-documentation Documentation needs to change as part of issue or PR comp-jans-cedarling Touching folder /jans-cedarling kind-feature Issue or PR is a new feature request labels Jan 2, 2025
nynymike
nynymike previously approved these changes Jan 2, 2025
View reviewed changes
@olehbozhok olehbozhok force-pushed the jans-cedaling-issue-10013 branch from 2f709f3 to 03ee0a5 Compare January 2, 2025 20:24
@olehbozhok
chore(jans-cedarling): remove dynamic = ["version"] from `pyproject…
9e5199e 
….toml` because it cause fail CI check

Signed-off-by: Oleh Bohzok <[email protected]>
@olehbozhok
chore(jans-cedarling): remove unused WASM code
f7968fb 
Signed-off-by: Oleh Bohzok <[email protected]>
@olehbozhok
chore(jans-cedarling): fix clippy issues
09e0582 
Signed-off-by: Oleh Bohzok <[email protected]>
@olehbozhok
docs(jans-cedarling): remove unnecessary part about optimization wasm.
0b3ef5f 
It is already optimized if used `--release` on build

Signed-off-by: Oleh Bohzok <[email protected]>
olehbozhok and others added 4 commits January 9, 2025 04:07
@olehbozhok
chore(jans-cedarling): update bootstrap to latest
87356f6 
Signed-off-by: Oleh Bohzok <[email protected]>
Signed-off-by: Oleh Bohzok <[email protected]>
Signed-off-by: Oleh Bohzok <[email protected]>
@olehbozhok
chore(jans-cedarling): add graceful error handling when init blocking…
010a8fd 
… client

Signed-off-by: Oleh Bohzok <[email protected]>
Signed-off-by: Oleh Bohzok <[email protected]>
Signed-off-by: Oleh Bohzok <[email protected]>
@olehbozhok
chore(jans-cedarling): fix test case, rename key kkk to key to av…
814e745 
…oid misinterpreted

Signed-off-by: Oleh Bohzok <[email protected]>
Signed-off-by: Oleh Bohzok <[email protected]>
Signed-off-by: Oleh Bohzok <[email protected]>
Signed-off-by: Oleh Bohzok <[email protected]>
@olehbozhok
chore(jans-cedarling): update documentation
784a627 
Signed-off-by: Oleh Bohzok <[email protected]>
Signed-off-by: Oleh Bohzok <[email protected]>
Signed-off-by: Oleh Bohzok <[email protected]>
Signed-off-by: Oleh Bohzok <[email protected]>
@olehbozhok olehbozhok force-pushed the jans-cedaling-issue-10013 branch from ca75c1f to 784a627 Compare January 9, 2025 02:08
@olehbozhok olehbozhok enabled auto-merge (squash) January 9, 2025 14:51
djellemah
djellemah previously approved these changes Jan 10, 2025
View reviewed changes
@olehbozhok olehbozhok force-pushed the jans-cedaling-issue-10013 branch from dca9344 to c1ac642 Compare January 10, 2025 14:42
@olehbozhok olehbozhok force-pushed the jans-cedaling-issue-10013 branch from 7509379 to 4510b9c Compare January 10, 2025 15:50
@olehbozhok olehbozhok dismissed abaghinyan’s stale review January 10, 2025 21:36

Suggesting was resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nynymike nynymike nynymike approved these changes

@djellemah djellemah djellemah approved these changes

@moabu moabu Awaiting requested review from moabu moabu is a code owner

@rmarinn rmarinn Awaiting requested review from rmarinn

@abaghinyan abaghinyan Awaiting requested review from abaghinyan

@duttarnab duttarnab Awaiting requested review from duttarnab

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
area-documentation Documentation needs to change as part of issue or PR comp-jans-cedarling Touching folder /jans-cedarling kind-feature Issue or PR is a new feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(jans-cedarling): add WASM bindings for Cedarling
8 participants
@olehbozhok @djellemah @nynymike @duttarnab @rmarinn @abaghinyan @mo-auto @moabu