-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cloud-native): secure mounted configuration schema #10577
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: iromli <[email protected]>
Signed-off-by: iromli <[email protected]>
…er level setup Signed-off-by: iromli <[email protected]>
Signed-off-by: iromli <[email protected]>
Quality Gate passed for 'agama parent'Issues Measures |
Quality Gate passed for 'jans-pycloudlib'Issues Measures |
Quality Gate passed for 'jans-linux-setup'Issues Measures |
Quality Gate passed for 'Jans-Keycloak-Link'Issues Measures |
Quality Gate passed for 'Fido2 API'Issues Measures |
Quality Gate passed for 'SCIM API'Issues Measures |
Quality Gate passed for 'jans-config-api-parent'Issues Measures |
Signed-off-by: iromli <[email protected]>
…nssen-all-in-one Signed-off-by: iromli <[email protected]>
Signed-off-by: iromli <[email protected]>
Signed-off-by: iromli <[email protected]>
Signed-off-by: iromli <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Key properties should be specified. We should indicate that only symmetric is supported and show what sizes are supported to limit possible errors and issues. Also we need to handle the case when an error occurs handling the key and act as if its empty when that happens skipping encryption/decryption.
Signed-off-by: iromli <[email protected]>
Signed-off-by: iromli <[email protected]>
Signed-off-by: iromli <[email protected]>
Hi @moabu , thanks for the review. I made several changes to address potential issue.
The new
Invalid key or invalid text is handled by Though there's an exception, the configurator job will throw error and kill the pod to ensure only valid configuration schema is mounted to pod (useful on first installation). |
Prepare
Description
Target issue
closes #10550
Implementation Details
Test and Document the changes
Please check the below before submitting your PR. The PR will not be merged if there are no commits that start with
docs:
to indicate documentation changes or if the below checklist is not selected.