Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Theme Filling Script #241

Closed

Conversation

painerp
Copy link
Contributor

@painerp painerp commented Sep 10, 2024

  • Removed Obsolete Values: Values that aren't in the complete theme anymore are now removed from all target themes.

  • Improved Log Readability: The script now prints just the filename instead of the whole path.

@Jas-SinghFSU
Copy link
Owner

Could there be a case that the 'complete' theme isn't actually fully complete and running the script would cause a regression in the other themes that are fully complete due to the property removal?

@painerp
Copy link
Contributor Author

painerp commented Sep 18, 2024

This is indeed a possibility. If I assessed the script correctly it assumes the 'complete' theme (by default catppuccin_mocha) to be the template and propagates all changes from it to the other themes.

In my opinion it isn't that big of a problem though since you clearly see the removed lines in the output of the script. We could potentially also change the color of the echo to be even more visible.

In the meantime, documenting this behavior would be a good idea, so that other contributors are aware of how the script works.

In the long run, automatically extracting all theme options would likely be wise, ensuring everything is present and making it less obscure which theme is the template.

@painerp painerp closed this Oct 5, 2024
@painerp painerp deleted the improve-theme-filling-script branch December 26, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants