Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #389. Prior PR assumed that
competition_name
inall_seasons.csv
would match what is shown on the FBRef page, but that doesn't always turn out to be the case, e.g. Bundesliga. I've made a change to remove string searching, and instead assume the points table is always the first on the page. I'm 99% sure that this should work for all leagues, although I haven't tested it comprehensively.Confirmed that this works.