This repository has been archived by the owner on Feb 9, 2022. It is now read-only.
lambda-prevout-provider fallback-prevout-provider
#128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monstrobishi
requested review from
canonbrother,
fuxingloh,
ivan-zynesis,
jingyi2811 and
thedoublejay
as code owners
|
Code Climate has analyzed commit 127fd9e and detected 0 issues on this pull request. View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## main #128 +/- ##
==========================================
- Coverage 97.93% 97.75% -0.19%
==========================================
Files 18 19 +1
Lines 242 267 +25
Branches 16 18 +2
==========================================
+ Hits 237 261 +24
- Misses 5 6 +1
Continue to review full report at Codecov.
|
ivan-zynesis
reviewed
Aug 5, 2021
| console.log(`Sent with txid: ${txid}`) | ||
| const prevout = await broadcastPrices(oraclesManager, env, prices) | ||
| if (prevout !== undefined) { | ||
| process.stdout.write(`${JSON.stringify(prevout)}`) |
There was a problem hiding this comment.
Suggested change
| process.stdout.write(`${JSON.stringify(prevout)}`) | |
| process.stdout.write(`${FALLBACK_PREVOUT_PREFIX} ${JSON.stringify(prevout)}`) |
With specific log group, literally we have partitioned, filterable time series DB :D
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of PR is this?:
/kind feature
What this PR does / why we need it:
As whale cannot technically "index" unconfirmed prevouts, it must rely on
listunspent => include_unsafe, which would be detrimental to whale infrastructure. The only other solution being that the client must keep track of prevouts. As Lambda does not persist state, nor do we want to maintain a database, an alternative implementation is required.This failsafe provider uses the cloudwatch logs to fetch the prevout used in the last transaction, in the case where this causes any kind of issue, the whale client provider is used as a fallback.
Which issue(s) does this PR fixes?:
Fixes #
Additional comments?: