Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VIM-3731] Add support for "jump to previous/next lowercase mark". #1068

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

sdoerner
Copy link
Contributor

Fixes VIM-3731.

Let me know if I should do anything else with Mark.PositionSorter. The two data structures are in different packages, so I wasn't sure if sharing the code would be desired or where you'd want the shared code to live.

sdoerner added a commit to sdoerner/helix.vim that referenced this pull request Dec 15, 2024
These lead to issues and are not needed after merging the upstream
JetBrains/ideavim#1068.

Fixes: chtenb#3
@lippfi lippfi self-assigned this Jan 13, 2025
@mbouron
Copy link

mbouron commented Jan 18, 2025

For what it's worth, I've been running this PR applied on top of latest master for the last few days and it works as expected.

@lippfi
Copy link
Contributor

lippfi commented Jan 20, 2025

For what it's worth, I've been running this PR applied on top of latest master for the last few days and it works as expected.

I've just checked out the PR to recheck my comment to be sure
Nope, it doesn't
Set multiple marks at the same place and then press ]`

Expected result: caret is moved to the next mark
Actual result: caret is stuck no matter how many times you press ]`

@sdoerner
Copy link
Contributor Author

sdoerner commented Jan 21, 2025

I've just checked out the PR to recheck my comment to be sure Nope, it doesn't Set multiple marks at the same place and then press ]`

Expected result: caret is moved to the next mark
Actual result: caret is stuck no matter how many times you press ]`

Pushed an update to the PR with a fix.

@lippfi
Copy link
Contributor

lippfi commented Jan 21, 2025

Thank you for your work!
And thank you one more time for the tests, the number of tests is impressive.

@lippfi lippfi enabled auto-merge (rebase) January 21, 2025 20:39
@lippfi lippfi merged commit cb21869 into JetBrains:master Jan 21, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants