Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OC-925: Configure ECS task to run on a schedule #753

Merged
merged 5 commits into from
Jan 20, 2025
Merged

OC-925: Configure ECS task to run on a schedule #753

merged 5 commits into from
Jan 20, 2025

Conversation

finlay-jisc
Copy link
Collaborator

The purpose of this PR was to set up the ARI import ECS task to run automatically at a scheduled time. This should finish off the ECS solution, ready for its ongoing usage. On Tuesday mornings, an incremental update runs on int, and at the same time, a dry run incremental update runs on prod. The results will be checked on int and the output report emails will be reviewed before triggering a real incremental update on prod via the API endpoint.

The API code around the trigger endpoint has been tidied up and the naming has been updated to refer to ARI imports specifically rather than generic ECS triggering.

The code hasn't been deployed to prod yet but I have double checked that the dry run override works on the int trigger.


Acceptance Criteria:

  • A schedule rule exists that triggers the ARI import function at 5am on int and prod
    • On prod, this execution is a dry run
  • ARI import runs can be triggered (dry runs and actual runs) via the API endpoint

Checklist:

  • Local manual testing conducted
  • Automated tests added
  • Documentation updated

Tests:

API
Screenshot 2025-01-16 142844

E2E
Screenshot 2025-01-16 141927

@finlay-jisc finlay-jisc requested a review from a team as a code owner January 16, 2025 14:30
Copy link

@adwearing-jisc adwearing-jisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few potential improvements. No deal breakers, I think it's fine without, just possible to improve readability and terraform usage.

@finlay-jisc finlay-jisc merged commit ddb50cf into main Jan 20, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants