Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow passing external Progress for better composability #25

Merged
merged 4 commits into from
Nov 12, 2023
Merged

Allow passing external Progress for better composability #25

merged 4 commits into from
Nov 12, 2023

Conversation

kunaltyagi
Copy link
Contributor

No description provided.

@Johannes11833
Copy link
Owner

That's a good idea!
I noticed that pbar was not passed to _rclone_transfer_operation() and that pbar=None in rclone_progress() ignored the provided progressbar.

@Johannes11833 Johannes11833 merged commit 090ffce into Johannes11833:master Nov 12, 2023
1 check passed
@kunaltyagi kunaltyagi deleted the patch-2 branch November 12, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kunaltyagi @Johannes11833