add run! #5
Open
add run! #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| (m::Model)(params) = sum(params) + sum(m.options) | ||
| ``` | ||
| """ | ||
| function run!(method, model, data; |
There was a problem hiding this comment.
I'm starting to believe that maybe it is better not to talk about data at all, perhaps it is best to ask users to directly return a cost (or a vector of costs if it makes sense for some algorithms) in this way data could in principle change during inference in a user defined way, what do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a generic
run!method with some docs. This is the one I thought we should extend in other packages. In #1 I named itfit!but I think it was a good point by eford to not call it like this...