Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RemoteChannel iterator interface #100

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Fix RemoteChannel iterator interface #100

merged 1 commit into from
Jul 19, 2024

Conversation

danielwe
Copy link
Contributor

@danielwe danielwe commented Apr 10, 2024 •
edited
Loading

Just a missing import

@danielwe danielwe force-pushed the remotechannelsize branch 2 times, most recently from 282ad6a to 6abf60b Compare April 10, 2024 22:39
@danielwe
Copy link
Contributor Author

CI seems to be running new tests with old code

@LilithHafner
Copy link
Member

Strange. The source diff LGTM, and I can confirm locally that it fixes an undefined value error.

I don't know what is going on with the tests and am not familiar with the testing infrastructure of this repo.

@fatteneder
Copy link
Member

fatteneder commented Jul 19, 2024 •
edited
Loading

The rebase fixed the tests.
I also checked locally that the problem is fixed.
So I go ahead and merge this.

@fatteneder fatteneder merged commit 8e3f849 into JuliaLang:master Jul 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fatteneder fatteneder fatteneder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielwe @LilithHafner @fatteneder