Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix comparison to work with 0.21 #150

Merged
merged 2 commits into from
Oct 30, 2023
Merged

fix comparison to work with 0.21 #150

merged 2 commits into from
Oct 30, 2023

Conversation

lucaferranti
Copy link
Member

@lucaferranti lucaferranti commented Oct 29, 2023

now I get

(RangeEnclosures) pkg> st
Project RangeEnclosures v0.2.2
Status `~/.julia/dev/RangeEnclosures/Project.toml`
  [f6369f11] ForwardDiff v0.10.36
  [d1acc4aa] IntervalArithmetic v0.21.2
  [379f33d0] ReachabilityBase v0.2.0
  [ae029012] Requires v1.3.0

julia> h(x) = sin(x[1]) - cos(x[2]) - sin(x[1]) * cos(x[1])
h (generic function with 1 method)

julia> Dh = IntervalBox(-5 .. 5, -5 .. 5)
[-5.0, 5.0]²

julia> res = enclose(h, Dh, BranchAndBoundEnclosure())
[-2.71068, 2.71313]

fixes #149

@lucaferranti lucaferranti requested a review from schillic October 29, 2023 17:21
@lucaferranti
Copy link
Member Author

lucaferranti commented Oct 29, 2023

the issue was with a bug with how > and >= are defined in IA v0.21

@schillic
Copy link
Member

Can we test this somehow?

src/branchandbound.jl Outdated Show resolved Hide resolved
Co-authored-by: Christian Schilling <[email protected]>
@lucaferranti lucaferranti merged commit dd17c51 into master Oct 30, 2023
5 checks passed
@lucaferranti lucaferranti deleted the lf-issue branch October 30, 2023 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong answer for 2D example in docs
2 participants