Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow SDPA v0.6 in tests #196

Merged
merged 3 commits into from
Nov 9, 2024
Merged

Allow SDPA v0.6 in tests #196

merged 3 commits into from
Nov 9, 2024

Conversation

schillic
Copy link
Member

@schillic schillic commented Nov 8, 2024

This will probably resolve #195.

@schillic
Copy link
Member Author

schillic commented Nov 8, 2024

This is ugly. SDPA v0.6 crashes in Julia v1.6 but they forgot to raise the compatibility bounds, so it still installs the new version.

@mforets
Copy link
Member

mforets commented Nov 8, 2024

i would suggest removing 1.6 and test on the latest stable julia release

@schillic schillic marked this pull request as draft November 8, 2024 20:21
@schillic schillic marked this pull request as ready for review November 8, 2024 21:13
@schillic
Copy link
Member Author

schillic commented Nov 8, 2024

Yes, but nothing really changed. I found a workaround.

@schillic schillic merged commit d989827 into master Nov 9, 2024
7 checks passed
@schillic schillic deleted the schillic/sdpa branch November 9, 2024 08:32
@schillic schillic mentioned this pull request Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot run tests in Julia v1.12
2 participants